-
Notifications
You must be signed in to change notification settings - Fork 0
chore: switched to expo env variables and build number #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit d2ec896.
| "autoIncrement": true, | ||
| "environment": "preview" | ||
| }, | ||
| "production": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we "autoIncrement": true, for production as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Initially I though that it has one build number for all profiles but after some testing it seems that it is separate for each.
This reverts commit 3ac7627.
Description
This PR aligns the template with latest Expo developments that we had to until now substituted through custom Github Actions.
By making these changes we want to align more to a standard Expo workflows and remove complexity from our github actions that doesn't have to be there.
There is a mapping that should be just temporary until we fully align our environment names. For now all github actions environment names are mapped from our names to EAS names, dev -> development, staging -> preview, production -> production. This is done automatically in build and update actions. Just keep this in mind when you are setting environment variables directly in EAS dashboard.
How to migrate:
Related Tickets/Issues